Extend expression fuzzer test to support decimal

[rui-mo]

ArgumentTypeFuzzer could be used to generate argument types when constructing a
decimal expression in the fuzzer test. However, given a result type, it is
unable to produce argument types that satisfy the necessary constraints. To
address this limitation, argument type generators for Presto and Spark decimal
functions have been added. In this PR, ExpressionFuzzer takes a map from
function name to an instance of the argument generator. Custom generators
provided by Presto and Spark are used in the expression fuzzer test to generate
argument types. Experimental fuzzer tests with decimal type enabled will be
added in a follow-up PR.

#1968

[netlify]

✅ Deploy Preview for meta-velox canceled.

Name	Link
🔨 Latest commit	70cf156
🔍 Latest deploy log	https://app.netlify.com/sites/meta-velox/deploys/66d8f878d7dc8100087a45c3

[rui-mo]

Hi @mbasmanova, I drafted this PR to support decimal in expression fuzzer test. Tested decimal_add and decimal_between locally for 10 minutes each. Below are some next-steps I can think of.

• Verify other decimal functions as well (agg functions are tested in AggregationFuzzer, so they will not be covered in this PR).
• Fix CI issues and enable velox_fuzzer_enable_decimal_type in CI.
• Test decimal function registered as simple function when the relating PR is merged.

Besides that, do you have more items in mind which I should take care of to move forward? Thank you.

[mbasmanova]

@rui-mo Rui, thank you for extending Fuzzer to cover decimal types. Would you update the PR description to provide some details about the design of this extension? Are there any limitations?

@kagamiori @kgpai Krishna, Wei, would you help review this PR?

CC: @majetideepak @aditi-pandit

[rui-mo]

This PR is updated and ready for review. Thanks.

[majetideepak]

workflow changes look good!

[rui-mo]

@majetideepak @assignUser Thanks for your review. The workflow fails with below error as the main branch is used for testing. It should be fine after this PR is landed.

ERROR: unknown command line flag 'velox_fuzzer_enable_decimal_type'

[majetideepak]

@rui-mo A safer option is to move the dependent workflow changes to a new PR. It is always safer to avoid landing changes when CI is failing.

[rui-mo]

A safer option is to move the dependent workflow changes to a new PR. It is always safer to avoid landing changes when CI is failing.

@majetideepak Thanks for the suggestion. Removed workflow changes.

[majetideepak]

@rui-mo thanks! This PR is already approved and tagged for merging. Meta will merge this.

[rui-mo]

@xiaoxmeng Would you help import and merge this PR? Thanks.

[rui-mo]

Hi @xiaoxmeng, does this PR also require some internal work from Meta? Wondering if there is any chance to land this change first. Thanks.

[facebook-github-bot]

@gggrace14 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[assignUser]

The last commit in this PR was almost a month ago. Can we rebase it before merging please.

[rui-mo]

@assignUser @gggrace14 Rebased this PR, and the macOS build failure looks relevant to #10886. Would you take a another look? Thank you.

[assignUser]

Thanks!

[pedroerp]

We are seeing this problem where PRs that were created before we enabled the notification system do not trigger a ready-to-merge notification. Apologies for the delay on this one.

[facebook-github-bot]

@gggrace14 merged this pull request in 030e439.

[conbench-facebook]

Conbench analyzed the 1 benchmark run on commit 030e439f.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

[rui-mo]

@gggrace14 @pedroerp Thanks for noticing and helping land this PR!