Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

fix async for usage with python 3.7 #134

Closed
wants to merge 3 commits into from

Conversation

douglasrizzo
Copy link

In Python 3.7, async is a reserved word, so I changed it (there were only a few occurrences) to asynch. This has only affected .py files.

in python37, async is a reserved word, so I changed it
@facebook-github-bot
Copy link
Contributor

Hi douglasrizzo! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@douglasrizzo
Copy link
Author

I just tested it (without GPU) on Python 3.7 and everything works fine. I believe this fixes #124 and #127.

@douglasrizzo
Copy link
Author

OK, my fix didn't work when using the GPU.

I took a look at the documentation for the pytorch.Tensor object and, apparently, the async argument is not even used in the copy_ and cuda methods (which are the ones used in ELF), so I just deleted them. Now everything works.

@douglasrizzo
Copy link
Author

I had a problem on my side by pushing from my master branch. I created a new PR #135 from a new branch now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants