-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename FIFOOffPolicyReplayBuffer to SARSAReplayBuffer in tutorials #104
Conversation
Hi @yepw! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Thank you, this is very much appreciated! |
@rodrigodesalvobraz has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@rodrigodesalvobraz merged this pull request in ffdbc8a. |
@yepw , just so you know, it turns out your PR was incorrect and broke the tutorials. |
@rodrigodesalvobraz oooops, thank you for letting me know! |
FIFOOffPolicyReplayBuffer was renamed to SARSAReplayBuffer in a recent commit c5c692d, but the tutorial is not updated.