Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename FIFOOffPolicyReplayBuffer to SARSAReplayBuffer in tutorials #104

Closed
wants to merge 1 commit into from

Conversation

yepw
Copy link
Contributor

@yepw yepw commented Oct 27, 2024

FIFOOffPolicyReplayBuffer was renamed to SARSAReplayBuffer in a recent commit c5c692d, but the tutorial is not updated.

@facebook-github-bot
Copy link
Contributor

Hi @yepw!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 27, 2024
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@rodrigodesalvobraz
Copy link
Contributor

Thank you, this is very much appreciated!

@facebook-github-bot
Copy link
Contributor

@rodrigodesalvobraz has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@rodrigodesalvobraz merged this pull request in ffdbc8a.

@rodrigodesalvobraz
Copy link
Contributor

@yepw , just so you know, it turns out your PR was incorrect and broke the tutorials. SARSAReplayBuffer replaced FIFOOnPolicyReplayBuffer, not FIFOOffPolicyReplayBuffer (the correct replacement for that was BasicReplayBuffer). Also, the tutorials need to be re-run when altered. Of course we share responsibility since we didn't notice the problem before accepting the PR! In any case, we have fixed that and re-run the tutorials, so that should be ok now. Thanks.

@yepw
Copy link
Contributor Author

yepw commented Oct 30, 2024

@rodrigodesalvobraz oooops, thank you for letting me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants