Added sorting option for sentences during encoding #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
David-OC17
force-pushed
the
sorting_optimization
branch
from
1170739
to
fd6a2d0
Compare
David-OC17
force-pushed
the
sorting_optimization
branch
from
fd6a2d0
to
6fa7d05
Compare
artemru
reviewed
Nov 20, 2024
| read_text(input) | ||
| if isinstance(input, (str, Path)) | ||
| else read_sequence(input) | ||
| input_data |
There was a problem hiding this comment.
at the end we want to return vectors in the same order as their original texts, so we need to memorize argsort permutation and to apply the inverse one before returning the result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a sorting option that is meant to optimize encoding of sentences by reducing the amount of padding that is used to accommodate sentences for embedding into the SONAR space. Tests showcasing efficiency changes are missing, so far.