Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] add examples and minor updates #1071

Merged
merged 15 commits into from
Mar 24, 2025
Merged

[doc] add examples and minor updates #1071

merged 15 commits into from
Mar 24, 2025

Conversation

zyaoj
Copy link
Contributor

@zyaoj zyaoj commented Feb 27, 2025

What does this PR do? Please describe:

  • added a load model example to showcase model hub
  • revised dataset example given the latest changes
  • update nits in tutorials

Does your PR introduce any breaking changes? If yes, please list them:

N/A

Check list:

  • Was the content of this PR discussed and approved via a GitHub issue? (no need for typos or documentation improvements)
  • Did you read the contributor guideline?
  • Did you make sure that your PR does only one thing instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (no need for typos, documentation, or minor internal changes)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 27, 2025
@zyaoj zyaoj requested review from uralik and cbalioglu February 27, 2025 17:17
@zyaoj zyaoj changed the title add examples and minor updates [doc] add examples and minor updates Feb 27, 2025
@zyaoj zyaoj self-assigned this Mar 24, 2025
artemru
artemru approved these changes Mar 24, 2025
View reviewed changes
Copy link
Contributor

@artemru artemru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good !
can you go with black over notebooks ?

@zyaoj zyaoj merged commit a076110 into main Mar 24, 2025
2 checks passed
@zyaoj zyaoj deleted the zyaoj/doc-update-nightly branch March 24, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemru artemru artemru approved these changes

@uralik uralik Awaiting requested review from uralik

@cbalioglu cbalioglu Awaiting requested review from cbalioglu

Assignees

@zyaoj zyaoj

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zyaoj @artemru @facebook-github-bot