Skip to content

Commit

Permalink
Fix FBPCP pyre action workflow (pin to official latest pyre-check rel…
Browse files Browse the repository at this point in the history
…ease version in github action) (#530)

Summary:

FBPCP pyre action workflow has been broken (https://github.com/facebookresearch/fbpcp/actions/workflows/pyre.yml) since this change
facebook/pyre-check@d3164ae.

FBPCP takes pyre-check-nightly which is a beta version of pyre-check that is not compatible with Python3.8 (where our OSS is using).  To fix this, let’s pin to latest offical pyre-check latest version pyre-check==0.9.19.

https://pypi.org/project/pyre-check/#history

Reviewed By: tgamal, ajinkya-ghonge

Differential Revision: D57057873
  • Loading branch information
David Wu authored and facebook-github-bot committed May 7, 2024
1 parent 606df94 commit cd29eae
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/pyre.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
python3 -m venv env
source env/bin/activate
python3 -m pip install .
python3 -m pip install pyre-check-nightly~=0.0.10
python3 -m pip install pyre-check==0.9.19
- name: Run Pyre
run: |
source env/bin/activate
Expand Down

0 comments on commit cd29eae

Please sign in to comment.