Skip to content

Commit

Permalink
Remove partial dependency in PCSContainerService (#405)
Browse files Browse the repository at this point in the history
Summary:
X-link: facebookresearch/fbpcp#405

We decided that validate_container_definitions should not be a public API in container service. This diff is to remove it and resolve the conflict.

The validation logic has been moved in D38629555, to ensure the backward compatibility, we firstly changed the function body to ``pass``.

Differential Revision: D38604420

fbshipit-source-id: 9d9d6480863ea9ebb68ca5a84c53cc2aecf8ddfe
  • Loading branch information
zhuang-93 authored and facebook-github-bot committed Aug 11, 2022
1 parent c81acfd commit b49e1cb
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions fbpcs/common/service/pcs_container_service.py
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,4 @@ def get_current_instances_count(self) -> int:
return self.inner_container_service.get_current_instances_count()

def validate_container_definition(self, container_definition: str) -> None:
return self.inner_container_service.validate_container_definition(
container_definition
)
pass

0 comments on commit b49e1cb

Please sign in to comment.