Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--Set default fallback material handling #2265

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

--Set default fallback material handling #2265

wants to merge 3 commits into from

Conversation

jturner65
Copy link
Contributor

Motivation and Context

This PR provides some extensions to the fall back material handling.

  • Make the fallback material magenta color
  • Add a boolean to drawables to denote they are being shaded via the fallback color. This will signify that either the materials were not loaded or they do not exist for the source asset
  • Add a reporting tool to provide information to the user about all assets/objects that ended up being configured to consume the fallback material instead of an appropriate asset-related material.

Still a WIP

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 14, 2023
@jturner65 jturner65 force-pushed the DfltFallbackMaterials branch 2 times, most recently from 2ac3229 to 41b6fcc Compare November 29, 2023 14:33
@jturner65 jturner65 force-pushed the DfltFallbackMaterials branch 4 times, most recently from 579d931 to 4f114ba Compare December 12, 2023 17:24
@jturner65 jturner65 force-pushed the DfltFallbackMaterials branch from 4f114ba to 4d3b00c Compare December 18, 2023 17:17
@jturner65 jturner65 force-pushed the DfltFallbackMaterials branch 2 times, most recently from 5a87217 to 419dd20 Compare January 4, 2024 13:52
@jturner65 jturner65 force-pushed the DfltFallbackMaterials branch 2 times, most recently from dfe520d to 92ac4da Compare January 9, 2024 21:12
@jturner65 jturner65 force-pushed the DfltFallbackMaterials branch 2 times, most recently from 38996c7 to 15dbe47 Compare January 29, 2024 19:22
@jturner65 jturner65 force-pushed the DfltFallbackMaterials branch 3 times, most recently from df87790 to a25b8c6 Compare February 7, 2024 16:00
@jturner65 jturner65 force-pushed the DfltFallbackMaterials branch 2 times, most recently from 1a31f92 to 169946d Compare February 15, 2024 14:08
@jturner65 jturner65 force-pushed the DfltFallbackMaterials branch 2 times, most recently from 8f74add to d06df58 Compare February 26, 2024 17:29
@jturner65 jturner65 force-pushed the DfltFallbackMaterials branch 4 times, most recently from b2d5dc8 to 37554a4 Compare March 5, 2024 19:04
@jturner65 jturner65 force-pushed the DfltFallbackMaterials branch 4 times, most recently from 3e348b4 to f545426 Compare March 20, 2024 16:15
@jturner65 jturner65 force-pushed the DfltFallbackMaterials branch from f545426 to a432c4f Compare April 3, 2024 17:26
@jturner65 jturner65 force-pushed the DfltFallbackMaterials branch 2 times, most recently from 882fae3 to 49134be Compare September 10, 2024 13:40
@jturner65 jturner65 changed the base branch from main to dev September 13, 2024 13:03
@jturner65 jturner65 requested review from aclegg3 and 0mdc September 13, 2024 13:03
@jturner65 jturner65 force-pushed the DfltFallbackMaterials branch from 49134be to 7cb42c4 Compare September 17, 2024 14:25
@jturner65 jturner65 force-pushed the DfltFallbackMaterials branch 2 times, most recently from 69098c0 to 600eeea Compare September 18, 2024 17:15
@jturner65 jturner65 force-pushed the DfltFallbackMaterials branch from 600eeea to 174a7ef Compare October 29, 2024 21:08
Base automatically changed from dev to main November 4, 2024 16:35
@jturner65 jturner65 force-pushed the DfltFallbackMaterials branch 2 times, most recently from 60870c3 to af3c243 Compare November 11, 2024 16:04
@jturner65 jturner65 force-pushed the DfltFallbackMaterials branch 3 times, most recently from 0356ecf to ab80e95 Compare November 18, 2024 19:02
@jturner65 jturner65 force-pushed the DfltFallbackMaterials branch from ab80e95 to f021855 Compare November 25, 2024 19:39
@jturner65 jturner65 force-pushed the DfltFallbackMaterials branch 2 times, most recently from 5a592c3 to 7d6311b Compare December 11, 2024 14:35
@jturner65 jturner65 force-pushed the DfltFallbackMaterials branch from 7d6311b to f4e05d2 Compare January 15, 2025 14:52
@jturner65 jturner65 force-pushed the DfltFallbackMaterials branch 3 times, most recently from 360bb6a to 697ee37 Compare January 28, 2025 15:41
@jturner65 jturner65 force-pushed the DfltFallbackMaterials branch 2 times, most recently from f6f2c67 to a99b01f Compare February 10, 2025 14:31
@jturner65
--initial commit; Make fallback material noticeable
fd2c54f 
--make material color magenta
--add flag that this material is a fallback for an object lacking any other materials
--remove default phong material function; specifying phong shader to use should be sufficient for depth sensor.
@jturner65
--set flag when a drawable is built using fallback material
4ce733d 
--this could indicate that the source asset lacks a material, or else that no materials were loaded by design (i.e. for depth sensor).
@jturner65
--fallback should be flat
41880a7
@jturner65 jturner65 force-pushed the DfltFallbackMaterials branch from a99b01f to 41880a7 Compare February 14, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclegg3 aclegg3 Awaiting requested review from aclegg3

@0mdc 0mdc Awaiting requested review from 0mdc

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jturner65 @facebook-github-bot