Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[prototype] marker annotation util #2366

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

[prototype] marker annotation util #2366

wants to merge 18 commits into from
+2,614 −567

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Apr 22, 2024

Motivation and Context

DO NOT MERGE

Added examples/viewer.py marker annotation tool.

Related to facebookresearch/habitat-lab#1824

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aclegg3 aclegg3 requested a review from jturner65 April 22, 2024 17:04
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Apr 22, 2024
jturner65 and others added 18 commits April 26, 2024 06:58
@jturner65
--add markersets alias class
d573c48 
Intended to provide convenience access to markersets hierarchy
@jturner65
--Add MarkerSets.h; Specialize interaction to be MarkerSets class
09789b8
@jturner65
--modify wrapper access to be just through sorted list of marker points.
3480838
@jturner65
--clang-tidy
ee811b1
@jturner65
--add function to rekey Configuration values.
188885b 
This function will replace the original keys for all the values in a configuration (regardless of type) with sequential numeric strings preserving the natural ordering of the original set of keys
@jturner65
--increase array key limit to 1000 elements from 100
4eb9e41 
The constructed key for array values is formatted  with a fixed-width leading-zero numeric string so that it will always sort properly.
@jturner65
--add rekeying to markersets after they are loaded.
edd872e
@jturner65
--add MarkerSets accessors for all possible permutations
b6f60d9
@jturner65
--cleanup
b1d0cc6
@jturner65
-- clang-tidy
cf99b77
@jturner65
--make sure we clear out existing markers before we write new ones.
702ec10
@jturner65
--bindings for subsets, link sets
92fe289
@jturner65
--Finish bindings, cleanup LinkMarkerSet
74c5c8c
@jturner65
--clarify rekeying
761da98
@jturner65
--rename hierarchy components for clarity and brevity
75df840
@jturner65
--need to hide ArticulatedLink getScale (inherited from RigidBase)
c376d90 
This is not currently available for an ArticulatedLink and as it is it would break if ever attempted.
@jturner65
--transform points between object local and world points
9089ebb
@aclegg3 @jturner65
marker annotation util
826ded9
@jturner65 jturner65 force-pushed the alex-04_22-marker_set_util branch 3 times, most recently from 32faa3c to 826ded9 Compare April 29, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jturner65 jturner65 Awaiting requested review from jturner65

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aclegg3 @facebook-github-bot @jturner65