[BE] github actions migration #2422
Conversation
aclegg3
added
the
do not merge
facebook-github-bot
added
the
CLA Signed
|
@aclegg3 EGL initialization on the Actions runner now works correctly. You may still have issues with the CUDA build - let me know if that happens. |
| - name: setup | ||
| run: |- | ||
| pip install -U pip | ||
| pip install -U --prefer-binary \ |
There was a problem hiding this comment.
We should pin all dependencies here, especially complex ones like numpy.
This could be done from a requirements_ci.txt file.
| # Disable clone protection for git lfs | ||
| export GIT_CLONE_PROTECTION_ACTIVE=false | ||
|
|
||
| sudo apt install git-lfs |
There was a problem hiding this comment.
I would move LFS installation to a separate actions.yml workflow, along with all other basic setup steps.
| python src_python/habitat_sim/utils/datasets_download.py --uids ci_test_assets ycb rearrange_dataset_v2 --replace --data-path data/ --no-prune | ||
| ls -la data/scene_datasets/habitat-test-scenes/ | ||
| - name: Debugging with tmate | ||
| uses: mxschmitt/[email protected] |
…ry removing some "fluff" from testing to see if necessary
| sudo mkdir /opt/cmake312 | ||
| sudo sh ./cmake-3.12.4-Linux-x86_64.sh --prefix=/opt/cmake312 --skip-license | ||
| sudo ln -s /opt/cmake312/bin/cmake /usr/local/bin/cmake | ||
| sudo ln -s /opt/cmake312/bin/ctest /usr/local/bin/ctest |
There was a problem hiding this comment.
I would simplify this with sudo apt install -y cmake.
There was a problem hiding this comment.
Can try this and see if it works. 👍
There was a problem hiding this comment.
Nah, cmake isn't available on apt. I think that's the reason for this installation method initially.
Anyway, feel free to fiddle with it as a follow-up.
| tags: [ "v*" ] | ||
| schedule: | ||
| - cron: "0 5 * * *" | ||
| #this is 9PM PST |
| assert not config.has_value("test") | ||
| # TODO: this line segfaults on some platforms, investigate | ||
| # config.remove("test") | ||
| # assert not config.has_value("test") |
There was a problem hiding this comment.
This is pretty strange. Do you have an idea of what could be going on here?
There was a problem hiding this comment.
I have this issue on my local platform (Fedora 40) also. I spoke to John about it. His guess is that the more recent compilers may be treating some C++ code differently in the Configuration string manipulation system. E.g. I have gcc 14 here. He's looking into it, but for now we'll disable this one line. It really only hits when trying to remove a string key from a Configuration which I don't think we ever do anywhere downstream.
There was a problem hiding this comment.
(Putting this here for posterity) Yeah, specifically removing a string key to a string field in a raw configuration only.
Motivation and Context
Working branch to test migration to github actions. Do not merge.
How Has This Been Tested
CI
Types of changes
Checklist