Add the world size info in NCCL metadata #100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D50439185 |
yoyoyocmu
added a commit
to yoyoyocmu/torch_ucc
that referenced
this pull request
Oct 23, 2023
Summary: X-link: pytorch/pytorch#111639 This diff adds the world size info in NCCL metadata, as we need the information to calculate the algorithmic bandwidth and bus Bandwidth. Reviewed By: aaronenyeshi Differential Revision: D50439185
yoyoyocmu
force-pushed
the
export-D50439185
branch
from
943e87c to
9965e9a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50439185 |
yoyoyocmu
added a commit
to yoyoyocmu/torch_ucc
that referenced
this pull request
Oct 23, 2023
Summary: X-link: pytorch/pytorch#111639 This diff adds the world size info in NCCL metadata, as we need the information to calculate the algorithmic bandwidth and bus Bandwidth. Reviewed By: aaronenyeshi Differential Revision: D50439185
yoyoyocmu
force-pushed
the
export-D50439185
branch
from
9965e9a to
aad4f91
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50439185 |
aaronenyeshi
approved these changes
Oct 23, 2023
|
Need to find a maintainer to help run CI, and approve this as well |
Summary: X-link: pytorch/pytorch#111639 This diff adds the world size info in NCCL metadata, as we need the information to calculate the algorithmic bandwidth and bus Bandwidth. Reviewed By: aaronenyeshi Differential Revision: D50439185
yoyoyocmu
force-pushed
the
export-D50439185
branch
from
aad4f91 to
e7bf7d7
Compare
yoyoyocmu
added a commit
to yoyoyocmu/pytorch
that referenced
this pull request
Oct 23, 2023
…#111639) Summary: X-link: facebookresearch/torch_ucc#100 This diff adds the world size info in NCCL metadata, as we need the information to calculate the algorithmic bandwidth and bus Bandwidth. Test Plan: **Tested together with stacked diffs**: - Trace: https://fburl.com/perfdoctor/ke1d4g2z - The information is shown as `Group size` in the trace: {F1125504721} Reviewed By: aaronenyeshi Differential Revision: D50439185
|
This pull request was exported from Phabricator. Differential Revision: D50439185 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This diff adds the world size info in NCCL metadata, as we need the information to calculate the algorithmic bandwidth and bus Bandwidth.
Differential Revision: D50439185