Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post collectives from progress thread #18

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Sergei-Lebedev
Copy link
Contributor

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 7, 2021
@facebook-github-bot
Copy link
Contributor

@kingchc has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary:
Pull Request resolved: facebookresearch#9

- Add `getFuture` and relevant functions to support proper synchronization on CUDA stream
- Remove `SAVE_TENSOR`, use `SAVE_TENSORS` to cover all cases
- build and runtime flags to enable/disable this feature
  - build flag: `-DUSE_UCC_FUTURE`
  - runtime env. variable: `TORCH_UCC_USE_FUTURE=1`

Differential Revision: D29272193

fbshipit-source-id: 68fdd076e0d72069910c4f9ba3149e39bad5bda6
@Sergei-Lebedev Sergei-Lebedev force-pushed the topic/post_from_progress_thread branch 2 times, most recently from 26aa619 to 3de315f Compare July 7, 2021 21:28
@facebook-github-bot
Copy link
Contributor

@kingchc has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@Sergei-Lebedev Sergei-Lebedev force-pushed the topic/post_from_progress_thread branch from 3de315f to 318f06e Compare July 9, 2021 13:57
@facebook-github-bot
Copy link
Contributor

@kingchc has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot
Copy link
Contributor

@kingchc has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@kingchc kingchc mentioned this pull request Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants