Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include algorithm to fix build fail #165

Closed
wants to merge 1 commit into from

Conversation

ojh6404
Copy link
Contributor

@ojh6404 ojh6404 commented Oct 27, 2024

I encountered problem when I build with "ninja all" command

/home/leus/prog/vrs/vrs/helpers/JobQueue.h: In member function 'void vrs::JobQueue<T>::cancelQueuedJobs(std::function<bool(const T&)>, std::function<void(const T&)>)':
/home/leus/prog/vrs/vrs/helpers/JobQueue.h:118:22: error: 'remove_if' is not a member of 'std'; did you mean 'remove_cv'?
  118 |     auto iter = std::remove_if(queue_.begin(), queue_.end(), selector);


/home/leus/prog/vrs/vrs/test/DataLayoutTest.cpp:146:42: error: 'count' was not declared in this scope
  146 |   size_t lineCount = static_cast<size_t>(count(json.begin(), json.end(), '\n'));

This PR will fix problem above.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 27, 2024
@facebook-github-bot
Copy link
Contributor

@georges-berenger has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@georges-berenger
Copy link
Contributor

thanks for the code change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants