Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opt-in to python 3.8 plugin_host #635

Merged
merged 1 commit into from
Sep 8, 2024
Merged

Opt-in to python 3.8 plugin_host #635

merged 1 commit into from
Sep 8, 2024

Conversation

deathaxe
Copy link
Contributor

@deathaxe deathaxe commented Sep 8, 2024

This PR opts-in BracketHighlighter to python 3.8 plugin_host and resolves a py38 compatibility issue by removing verbose argument from named tuple creation.

@gir-bot gir-bot added S: needs-review Needs to be reviewed and/or approved. C: infrastructure Related to project infrastructure. C: plugins Related to plugins. C: search Related to search. C: source Related to source code. labels Sep 8, 2024
@facelessuser
Copy link
Owner

@gir-bot lgtm

@gir-bot gir-bot added S: approved The pull request is ready to be merged. and removed S: needs-review Needs to be reviewed and/or approved. labels Sep 8, 2024
@facelessuser facelessuser merged commit d51872e into facelessuser:master Sep 8, 2024
6 checks passed
@deathaxe deathaxe deleted the opt-in-python38 branch September 8, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C: infrastructure Related to project infrastructure. C: plugins Related to plugins. C: search Related to search. C: source Related to source code. S: approved The pull request is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deathaxe @facelessuser @gir-bot