Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions to test project from PHP 7.3 to PHP 8.2 #7

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

angeloLed
Copy link
Member

No description provided.

@angeloLed angeloLed requested a review from Negator1989 January 9, 2023 11:03
Copy link

@Negator1989 Negator1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

composer.json Outdated Show resolved Hide resolved
.github/workflows/tests.yaml Outdated Show resolved Hide resolved
@davidecaruso
Copy link
Member

davidecaruso commented Feb 7, 2023

Hi @angeloLed,
Scrutinizer inspections fail because of incompatibilities between the php-cs-fixer package and the desired PHP version (8.2). php-cs-fixer is a dependency of facile-it/facile-coding-standard, and does support only PHP ^8.1 right now.

However, this pull request will also need an update of the above mentioned package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants