Fix deprecated warning using mongodb extension 1.20 or greater in Rea…

…dPrederence::getMode() (#187) * Fix deprecated warning using mongodb extension 1.20 or greater in ReadPrederence::getMode() * Update src/Capsule/Collection.php Co-authored-by: Alessandro Lai <[email protected]> * Add new configuration on ci workflow * Extract a method to assert read preference mode * Revert test name --------- Co-authored-by: Oriol Parcerisa <[email protected]> Co-authored-by: Alessandro Lai <[email protected]>
facile-it · Oct 4, 2024 · dae724a · dae724a
1 parent 6e4b31f
commit dae724a
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 1 deletion.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -33,6 +33,10 @@ jobs:
             mongo-ext: 1.6.0
             mongo-img: 4.2
             symfony: "^4.4"
+          - php: 7.4
+            mongo-ext: 1.20.0
+            mongo-img: 5.0
+            symfony: "^4.4"
           - php: 8.1
             mongo-ext: 1.12.0
             mongo-img: 5.0

diff --git a/src/Capsule/Collection.php b/src/Capsule/Collection.php
@@ -206,6 +206,10 @@ private function prepareQuery(string $method, $filters, $data, array $options):
 
     private function translateReadPreference(ReadPreference $readPreference): string
     {
+        if (method_exists(ReadPreference::class, 'getModeString')) {
+            return $readPreference->getModeString();
+        }
+
         switch ($readPreference->getMode()) {
             case ReadPreference::RP_PRIMARY:
                 return 'primary';

diff --git a/tests/Unit/Capsule/DatabaseTest.php b/tests/Unit/Capsule/DatabaseTest.php
@@ -48,6 +48,16 @@ public function test_withOptions(): void
         $debugInfo = $newDb->__debugInfo();
         self::assertSame($manager, $debugInfo['manager']);
         self::assertEquals('testdb', $debugInfo['databaseName']);
-        self::assertEquals(ReadPreference::RP_NEAREST, $debugInfo['readPreference']->getMode());
+
+        $this->assertReadPreferenceMode($debugInfo['readPreference']);
+    }
+
+    public function assertReadPreferenceMode(ReadPreference $readPreference): void
+    {
+        if (method_exists(ReadPreference::class, 'getModeString')) {
+            self::assertEquals(ReadPreference::NEAREST, $readPreference->getModeString());
+        } else {
+            self::assertEquals(ReadPreference::RP_NEAREST, $readPreference->getMode());
+        }
     }
 }