Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Symfony 7 #144

Merged
merged 13 commits into from
Jan 25, 2024
Merged

Allow Symfony 7 #144

merged 13 commits into from
Jan 25, 2024

Conversation

Jean85
Copy link
Member

@Jean85 Jean85 commented Jan 15, 2024

DO NOT MERGE - on top / targets Follows #133

@Jean85 Jean85 self-assigned this Jan 15, 2024
@Jean85 Jean85 force-pushed the add-symfony-7-support branch from 696deac to cbc0619 Compare January 16, 2024 08:26
Base automatically changed from 2311_drop_symfony_34 to master January 25, 2024 05:48
@ilario-pierbattista
Copy link
Member

ilario-pierbattista commented Jan 25, 2024

@Jean85 is it ok for you if we merge also #146 before?

@Jean85
Copy link
Member Author

Jean85 commented Jan 25, 2024

Yes! This one just build up onto that

src/Capsule/Collection.php Outdated Show resolved Hide resolved
@Jean85 Jean85 marked this pull request as ready for review January 25, 2024 08:13
Copy link
Member

@ilario-pierbattista ilario-pierbattista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilario-pierbattista ilario-pierbattista merged commit 25065ef into master Jan 25, 2024
7 checks passed
@ilario-pierbattista ilario-pierbattista deleted the add-symfony-7-support branch January 25, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants