Adds "other actions" dropdown to ResourceHeader
#1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
nlopin
force-pushed
the
resource-header/other-actions
branch
from
46781ce to
ef15e6c
Compare
🔍 Visual review for your branch is published 🔍Here are the links to: |
nlopin
force-pushed
the
resource-header/other-actions
branch
from
db17aa8 to
e4fcc63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces new
otherActionsprop toResourceHeaderandBaseHeader. It accepts the list of actions and shows a dropdown with themI also created a new dropdown component for mobile, which shows a bottom sheet as per Figma design, but I'm a bit hesitant to have two components under the same roof of Dropdown. What do you think about the approach?
Screenshots
CleanShot.2025-01-09.at.15.35.45.mp4