Fix Dropdown item styles #1031
Merged
Fix Dropdown item styles #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Visual review for your branch is published 🔍Here are the links to: |
josepjaume
reviewed
Jan 10, 2025
Comment on lines
+43
to
+46
| const itemClass = cn( | ||
| "flex items-start gap-1.5 w-full", | ||
| item.critical && "text-f1-foreground-critical" | ||
| ) |
There was a problem hiding this comment.
Sometimes I wonder to which extend Tailwind's JIT will detect things that are not obviously class names. This is quite obvious, but maybe the original issue was related?
There was a problem hiding this comment.
I think it was radix, not the tailwind. I literally cut-and-pasted the component back and it worked
josepjaume
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a mystery, but the moment the item component is extracted to a separate file, it looses wrapping styles