Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Header metadata actions in mobile #1063

Merged
merged 3 commits into from
Jan 20, 2025
Merged

Conversation

dani-moreno
Copy link
Collaborator

Description

Metadata actions were hidden on smaller screens. This PR makes them accessible via the MobileDropdown component.

Also updated the Drawer design to match our Figma specs. Worked through a bunch of live fixes with Mario.

Screenshots

Screen.Recording.2025-01-16.at.18.11.42.mov

Metadata actions

image

How "other actions" look with the Drawer changes

Figma Link

Link to Figma Design


Type of Change

  • New experimental component
  • Promote component from experimental to stable
  • Maintenance / Bug Fix / Other

Copy link

github-actions bot commented Jan 16, 2025

🔍 Visual review for your branch is published 🔍

Here are the links to:

@dani-moreno dani-moreno marked this pull request as ready for review January 16, 2025 17:22
@dani-moreno dani-moreno requested a review from a team as a code owner January 16, 2025 17:22
Copy link
Contributor

@CarlosBM18 CarlosBM18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious, how this look like on the web? I mean, the bottom sheet.

Copy link
Collaborator

@josepjaume josepjaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

lib/experimental/Information/Headers/Metadata/index.tsx Outdated Show resolved Hide resolved
@nlopin
Copy link
Contributor

nlopin commented Jan 20, 2025

We show this horizontal handler bar. On mobile they mean you can pull it up for the drawer to take the full screen. We don't have that functionality. Why do we need it then?

@dani-moreno dani-moreno merged commit 09dd509 into main Jan 20, 2025
9 checks passed
@dani-moreno dani-moreno deleted the more-resourceheader-fixes branch January 20, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants