add checkbox example to factorial form #1084
Conversation
🔍 Visual review for your branch is published 🔍Here are the links to: |
| @@ -12,6 +12,7 @@ import { z, ZodType } from "zod" | |||
|
|
|||
| export const buildFormSchema = z.object | |||
| export const stringField = z.string | |||
| export const booleanField = z.boolean | |||
There was a problem hiding this comment.
I'm not fully sure of this approach for this. This obscures the use of the Zod library, I think I would prefer to know what I'm using. @josepjaume Any thoughts of getting rid of this in a future PR? I'm thinking of doing an example of nested schemas and I think this approach is not the best for it.
There was a problem hiding this comment.
I think you might be right and I was aware it could cause issues with nested schemas. Feel free to simplify the API and make the dependencies more explicit :)
DavidRodriguezHidalgo
force-pushed
the
feature/add_checkbox_to_form_example
branch
from
ef6a23a to
a4a792f
Compare
| @@ -5,6 +5,7 @@ type CheckboxProps = Omit< | |||
| "asChild" | |||
| > & { | |||
| title?: string | |||
| onCheckedChange?: (checked: boolean) => void | |||
There was a problem hiding this comment.
what about built in onChange? doesn't it work?
There was a problem hiding this comment.
nop. I already try with onChange to make it more consistent but it wasn't updating the values. I checked the library and it seems it doesn't support the onChange.
DavidRodriguezHidalgo
deleted the
feature/add_checkbox_to_form_example
branch
Description
Recently we added Checkbox field to form fields but we didn't add it to the form example.
Screenshots (if applicable)
Type of Change