Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add correct spacing for HomeLayout component #867

Merged
merged 5 commits into from
Nov 28, 2024
Merged

Add correct spacing for HomeLayout component #867

merged 5 commits into from
Nov 28, 2024

Conversation

sauldom102
Copy link
Contributor

@sauldom102 sauldom102 commented Nov 20, 2024 •
edited
Loading

Description

Add correct spacing for HomeLayout component.

Screenshots

Screenshot 2024-11-20 at 12 45 52 Screenshot 2024-11-20 at 13 14 07

⚠️ We'll need to polish the spacing around the carousel of widgets in order not to get cut, we have a new component upcoming https://github.com/factorialco/factorial-one/pull/868/files

@sauldom102 sauldom102 requested a review from a team as a code owner November 20, 2024 11:45
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 20, 2024 •
edited
Loading

🔍 Visual review for your branch is published 🔍

Here are the links to:

@sauldom102 sauldom102 marked this pull request as draft November 20, 2024 11:56
@sauldom102 sauldom102 marked this pull request as ready for review November 28, 2024 11:44
@sauldom102 sauldom102 merged commit 2b0d255 into main Nov 28, 2024
10 checks passed
@sauldom102 sauldom102 deleted the add-correct-spacing-for-homelayout branch November 28, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliseo-juan eliseo-juan eliseo-juan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sauldom102 @eliseo-juan