Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix main content width #909

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Fix main content width #909

merged 1 commit into from
Nov 28, 2024

Conversation

josepjaume
Copy link
Collaborator

Description

The width of the page container needs to be constrained somehow, or otherwise it overlaps the sidebar. This fixes it.

Screenshots (if applicable)

None

Figma Link

None


Type of Change

  • New experimental component
  • Promote component from experimental to stable
  • Maintenance / Bug Fix / Other

@josepjaume josepjaume requested a review from a team as a code owner November 28, 2024 16:01
Copy link

🔍 Visual review for your branch is published 🔍

Here are the links to:

@nlopin
Copy link
Contributor

nlopin commented Nov 28, 2024

do you have before/after? I don't understand the issue and how overflow fixes it

@nlopin
Copy link
Contributor

nlopin commented Nov 28, 2024

I've just merged a fix in the monorepo. Please, verify, it keeps working after the update

@josepjaume
Copy link
Collaborator Author

Nice fix! They're actually solving two different things - they should work without issues.

@josepjaume josepjaume merged commit 95a5797 into main Nov 28, 2024
10 checks passed
@josepjaume josepjaume deleted the fix-main-width branch November 28, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants