Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make blur from private box more restrictive #912

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Make blur from private box more restrictive #912

merged 1 commit into from
Nov 29, 2024

Conversation

sauldom102
Copy link
Contributor

Description

Make blur from private box more restrictive.

  • Ensure that we do not "expose" information to screen readers.
  • Do not allow text selection when that's enabled.
  • Make blur a little less aggressive.

@sauldom102 sauldom102 requested a review from a team as a code owner November 29, 2024 09:59
@github-actions GitHub Actions
Copy link

🔍 Visual review for your branch is published 🔍

Here are the links to:

dani-moreno
dani-moreno approved these changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@dani-moreno dani-moreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! It looks a lot better with the less aggressive blur!

@sauldom102 sauldom102 enabled auto-merge (squash) November 29, 2024 10:23
@sauldom102 sauldom102 merged commit 1f59281 into main Nov 29, 2024
10 checks passed
@sauldom102 sauldom102 deleted the make-blur-more-restrictive branch November 29, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dani-moreno dani-moreno dani-moreno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sauldom102 @dani-moreno