Fixed user menu #958
Merged
Fixed user menu #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Visual review for your branch is published 🔍Here are the links to: |
nlopin
reviewed
Dec 11, 2024
josepjaume
reviewed
Dec 13, 2024
Comment on lines
44
to
68
| useEffect(() => { | ||
| const observerOptions = { threshold: [1] } | ||
|
|
||
| const createObserver = (callback: (isIntersecting: boolean) => void) => { | ||
| return new IntersectionObserver( | ||
| ([entry]) => callback(!entry.isIntersecting), | ||
| observerOptions | ||
| ) | ||
| } | ||
|
|
||
| const topObserver = createObserver(setIsScrolled) | ||
| const bottomObserver = createObserver(setHasScrollBottom) | ||
|
|
||
| if (topScrollDetectorRef.current) { | ||
| topObserver.observe(topScrollDetectorRef.current) | ||
| } | ||
| if (bottomScrollDetectorRef.current) { | ||
| bottomObserver.observe(bottomScrollDetectorRef.current) | ||
| } | ||
|
|
||
| return () => { | ||
| topObserver.disconnect() | ||
| bottomObserver.disconnect() | ||
| } | ||
| }, []) |
There was a problem hiding this comment.
Great work! But - you have this fantastic tool at your disposal useIntersectionObserver. It's in the usehooks-ts dependency 😉
https://usehooks-ts.com/react-hook/use-intersection-observer
There was a problem hiding this comment.
Ah right, thanks! That makes it a lot easier, haha :D
josepjaume
reviewed
Dec 13, 2024
Comment on lines
131
to
137
| <AnimatePresence> | ||
| {isScrolled && <ScrollShadow position="top" />} | ||
| </AnimatePresence> | ||
|
|
||
| <AnimatePresence> | ||
| {hasScrollBottom && <ScrollShadow position="bottom" />} | ||
| </AnimatePresence> |
nlopin
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the User menu to the bottom of the Sidebar, and adds a gradient style like the one we already have for scrolling the header.
This also requires to update Factorial to use the footer prop for the user menu in the Sidebar. I'll do it next.
Related: JIRA
Screenshots
Screen.Recording.2024-12-11.at.09.58.48.mov
Type of Change