always full height #978
Closed
always full height #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Visual review for your branch is published 🔍Here are the links to: |
|
@Rogermax feel free to use the merged version with props. I noticed that it changes layout UI tests quite significantly and I want to cross-check with the team if it is what we want to have |
|
@sauldom102 @josepjaume could you check the UI Tests for layouts? We change the vertical space significantly, so maybe it is no-go for us. From my side, I wouldn't do the change and kept the merged solution with the |
Perfect! |
|
I close this one since it breaks other layouts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We merge this PR: #962 with a pending change (make height always 100% not with an optional prop)