Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify label styles #993

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Unify label styles #993

merged 2 commits into from
Dec 20, 2024

Conversation

sauldom102
Copy link
Contributor

@sauldom102 sauldom102 commented Dec 19, 2024

Description

Unify label styles.

Screenshots

Screenshot 2024-12-19 at 16 44 27

Screenshot 2024-12-19 at 16 48 34

@sauldom102 sauldom102 requested a review from a team as a code owner December 19, 2024 15:46
Copy link

github-actions bot commented Dec 19, 2024

🔍 Visual review for your branch is published 🔍

Here are the links to:

@sauldom102 sauldom102 enabled auto-merge (squash) December 19, 2024 15:49
Copy link
Collaborator

@dani-moreno dani-moreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! 💅

@nlopin
Copy link
Contributor

nlopin commented Dec 20, 2024

Is it fine we have 5 different font configurations?

I think the fonts for the legend in the LineChart and in the ProgressBar should be the same, but they are slightly different.

@sauldom102
Copy link
Contributor Author

Is it fine we have 5 different font configurations?

I think the fonts for the legend in the LineChart and in the ProgressBar should be the same, but they are slightly different.

Probably we should unify those as well, but we need some confirmation from design, I'll update those in a next PR

@sauldom102 sauldom102 merged commit e8464a6 into main Dec 20, 2024
10 checks passed
@sauldom102 sauldom102 deleted the unify-labels-styles branch December 20, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants