-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump versions and CI #621
Merged
Merged
Bump versions and CI #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wirew0rm
commented
Sep 26, 2023
•
edited
Loading
edited
- bump the main java version from 11 to 17 and add a 21 build.
- bump javafx to 16
- all later versions trigger the memory leak check in our unittests. I followed it up to it being triggered by charts having at least one plugin, while an anonymous ChartPlugin does not trigger it. It seems to be triggered by the listener on the chartProperty having references to the chart in its Closure.
- bump all other plugin references
- except javadoc, which causes jigsaw/module-system related errors if updated to the most recent version.
- update github actions to current versions.
- address leftovers from the previous PRs
- Measurements: remove unused indicators
- UpdateAxisPlugin: disable for now since it was not completely implemented anyhow and has to be adapted to the event system
- EditDataSet: recompute selector ui element positions on axis or data changes
- CategoryAxis: reenable updating the labels from dataset labels
Pull Request ReportHey there! 👋 Here's a report on the changes, suggestions, bugs, improvements, and rating for the pull request. Changes
Suggestions
BugsNo bugs found. Improvements
|
wirew0rm
force-pushed
the
bumpVersions
branch
from
September 26, 2023 14:02
87e6548
to
cd01108
Compare
wirew0rm
force-pushed
the
bumpVersions
branch
from
September 26, 2023 14:08
cd01108
to
3095041
Compare
wirew0rm
force-pushed
the
bumpVersions
branch
from
September 26, 2023 14:14
3095041
to
5055480
Compare
wirew0rm
force-pushed
the
bumpVersions
branch
from
September 26, 2023 14:25
5055480
to
7591b41
Compare
wirew0rm
force-pushed
the
bumpVersions
branch
from
September 26, 2023 14:33
7591b41
to
87ac291
Compare
wirew0rm
force-pushed
the
bumpVersions
branch
from
September 26, 2023 14:46
87ac291
to
4c3522f
Compare
wirew0rm
force-pushed
the
bumpVersions
branch
from
September 27, 2023 14:43
849e8d4
to
c44c7b5
Compare
wirew0rm
force-pushed
the
bumpVersions
branch
from
September 27, 2023 16:27
c44c7b5
to
8f9a4d0
Compare
wirew0rm
force-pushed
the
bumpVersions
branch
from
September 27, 2023 16:31
8f9a4d0
to
2599a44
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.