-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wallet login #68
base: master
Are you sure you want to change the base?
Wallet login #68
Conversation
Overall, it looks interesting to me. I like that in general this method can support not only metamasks, but also hardware wallets.
Is importing a wallet a must? Is it possible to link an fdp account to another wallet address (not fdp) and then log in with it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH I don't know what is the real use-case for importing a portable wallet into a wallet handler and then try to retrieve that from there.
|
||
For the login to work with metamask, user should already have a portable account created with [fdp-create-account](https://github.com/fairDataSociety/fdp-create-account). | ||
|
||
As we know while creating a portable account users can provide a 12 word mnemonic phrase for the portable wallet or a 12 word mnemonic will be generated for them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we use portable account term for the account uploaded and encrypted in Swarm. In order to use that you only need to provide username
and password
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I am talking about the account creation process here.
|
||
As we know while creating a portable account users can provide a 12 word mnemonic phrase for the portable wallet or a 12 word mnemonic will be generated for them. | ||
|
||
This solution starts with importing the portable wallet into metamask. After that it is a two-step process |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if I already imported my key into Metamask, why would I retrieve its encrypted credentials?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Metamask will not give me the seed right!? we need the credentials to get the encrypted seed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why would I need the encrypted seed? the wallet is already imported into my wallet handler with the 12 words that you mentioned
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need the seed for pod addresses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but you already imported the HD wallet with the 12 recovery words from which you can derive any amount of pods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think metamask has a way of importing account with mnemonic, So we use a private key to import the root private key.
I'm not familiar with a way where we can generate another account from that imported wallet.
We can allow linking fdp account with other wallets, but this will make the process confusing in the future if we want to do some kind of transaction with the fdp account wallet similar to ens registration. |
No description provided.