-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new file preview #516
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When checking the preview, I came across the fact that when opening previews for .html/.pdf files in the preview window, the files are still downloaded. I believe that downloading can be disabled for unsupported file types.
wdyt?
} | ||
} | ||
|
||
setContent(text); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend only outputting a few lines or kb of text. If the size is large, mobile users may have problems.
Good point. I didn't pay attention that files were still being downloaded even if cannot be previewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels quite responsive now!
There is a suggestion to not show an error for an unsupported file type. An error is something that doesn't go according to plan. However, an unsupported format is normal and the error can be hidden.
(optional) Without error, the distance between the file name and its size can be increased to improve display. But if the distance between the elements is no less than between other elements, then you can leave it that way.
File preview reimplemented. Now it supports text files as well.