Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: folder label #520

Merged
merged 2 commits into from
Sep 25, 2023
Merged

fix: folder label #520

merged 2 commits into from
Sep 25, 2023

Conversation

tomicvladan
Copy link
Collaborator

The label "Folder" changed to "New Folder" in the drive menu.

Copy link
Contributor

@tamas6 tamas6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to create a pod now, blocking a 400 Bad request, not sure related to the changes or fdp-play isse. Anyway the log say something new (besode 404 and 400):

react-dom.development.js:86 Warning: componentWillUpdate has been renamed, and is not recommended for use. See https://reactjs.org/link/unsafe-component-lifecycles for details.

* Move data fetching code or side effects to componentDidUpdate.
* Rename componentWillUpdate to UNSAFE_componentWillUpdate to suppress this warning in non-strict mode. In React 18.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: Identicon

@tomicvladan
Copy link
Collaborator Author

@tamas6 That error can't be related to this PR, because this PR only changes one label. I tested, and created a pod without any problems. Most likely you tried to create a pod with some special character that is not allowed.

@tamas6
Copy link
Contributor

tamas6 commented Sep 21, 2023

@tamas6 That error can't be related to this PR, because this PR only changes one label. I tested, and created a pod without any problems. Most likely you tried to create a pod with some special character that is not allowed.

Do you use fdp-play?

@tomicvladan
Copy link
Collaborator Author

@tamas6 That error can't be related to this PR, because this PR only changes one label. I tested, and created a pod without any problems. Most likely you tried to create a pod with some special character that is not allowed.

Do you use fdp-play?

No, I'm using bee-1.

@tamas6
Copy link
Contributor

tamas6 commented Sep 21, 2023

@tamas6 That error can't be related to this PR, because this PR only changes one label. I tested, and created a pod without any problems. Most likely you tried to create a pod with some special character that is not allowed.

FDP-play related issue, cannot be else.

@tfius tfius merged commit 5fb946a into development Sep 25, 2023
2 checks passed
@tfius tfius deleted the fix/folder-label branch September 25, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants