Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: node-fetch version 3 -> 2 #143

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

TheBojda
Copy link
Contributor

I modified node-fetch from 3.3.2 to 2, which is a maintained but commonjs compatible version.

@TheBojda TheBojda requested a review from nugaon as a code owner June 14, 2024 09:18
@nugaon nugaon changed the title node-fetch version 3.3.2 -> 2 fix: node-fetch version 3 -> 2 Jun 14, 2024
Copy link
Collaborator

@nugaon nugaon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks to point out the issue with node-fetch

let's try to use latest minor version of the package.

@@ -48,7 +48,7 @@
"dockerode": "^4.0.2",
"ethers": "^5.7.2",
"furious-commander": "^1.7.1",
"node-fetch": "3.0.0-beta.9",
"node-fetch": "2",
Copy link
Collaborator

@nugaon nugaon Jun 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"node-fetch": "2",
"node-fetch": "^2",

after you changed please update package-lock.json

@nugaon nugaon mentioned this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants