fix: enhance pod password generation with zero byte check and update crypto-js to 4.2.0 #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #212
Issue affected the node version of fdp-storage. It was related to the random number shim created for ether.js. Later on, crypto-js was added, which required the shim to generate more random bytes. The shim was initially generating random numbers for uint8array, which is only 1/4 of the required bytes for uint32array. As a result, the remaining bytes were zeros in the node version, while everything worked fine in the browser version.
For autonomous detection of similar errors related to incorrect crypto data providers, a self-check method has been added to verify the generated bytes.