added refresh interval in ms for animations #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to cause a segfault when actually logging in for the doom animation, and when on the matrix animation, it causes the display to go blank whilst authenticating. May need some help here. |
…own when it's aready deferred could be the issue?
|
It seems like some code added to give up the TTY on authentication (commit c7f70ac) and then take it back afterwards caused a segmentation fault with the doom animation and potentially a double free. Temporarily removed that code until I figure out how to fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a configuration option that allows the user to set the time between animation frames in milliseconds called
animation_refresh_ms.Had to change around the animation code to separate updating the animation buffer and drawing to the terminal buffer a bit, and if there is an animation a new
std.time.Timeris used to check if enough time has passed to draw with an update.Sort of what I wanted out of #708