Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add snapshot test for all locales' character sets #3276

Merged
merged 9 commits into from
Mar 6, 2025

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Nov 24, 2024

Fixes #1934


Adds a snapshot test that checks which characters are used by a locale.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: test labels Nov 24, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Nov 24, 2024
@ST-DDT ST-DDT requested review from a team November 24, 2024 00:37
@ST-DDT ST-DDT self-assigned this Nov 24, 2024
Copy link

netlify bot commented Nov 24, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit ae1bdad
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/67c9dd0f50e59b000884fc95
😎 Deploy Preview https://deploy-preview-3276.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (1982431) to head (ae1bdad).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3276   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files        2811     2811           
  Lines      217414   217414           
  Branches      951      952    +1     
=======================================
  Hits       217359   217359           
  Misses         55       55           
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ST-DDT ST-DDT merged commit 62486af into next Mar 6, 2025
23 checks passed
@ST-DDT ST-DDT deleted the test/locale/character-sets branch March 6, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify that the locale data use the correct characters
2 participants