Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(finance): add ISO 4217 numerical codes to Currency object #3404

Merged
merged 25 commits into from
Mar 6, 2025
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
facfe98
feat(finance): Added ISO 4217 numerical codes to Currency object
Nfloc Feb 12, 2025
f745d8b
Merge branch 'next' into next
Nfloc Feb 17, 2025
56d12d5
feat(finance): numericCode module parameter
Nfloc Feb 17, 2025
2806f3a
feat(finance): el numericCode
Nfloc Feb 17, 2025
47a3fdf
feat(finance): en numericCode
Nfloc Feb 17, 2025
3c0728e
feat(finance): fa numericCode
Nfloc Feb 17, 2025
54c504e
feat(finance): fr numericCode
Nfloc Feb 17, 2025
b975620
feat(finance): zh_CN numericCode
Nfloc Feb 17, 2025
fc1fa76
feat(finance): update definition comments
Nfloc Feb 17, 2025
fbff6d7
test(finance): numericCode naming
Nfloc Feb 17, 2025
9231089
test(finance): numericCode naming
Nfloc Feb 17, 2025
e3c6b30
test(finance): numericCode naming
Nfloc Feb 17, 2025
a8091d6
Merge pull request #1 from faker-js/next
Nfloc Feb 19, 2025
0057f94
feat(finance): change numericCode to string
Nfloc Feb 19, 2025
fb08dfa
Merge pull request #2 from faker-js/next
Nfloc Feb 19, 2025
0ef3efe
feat(finance): update src module description
Nfloc Feb 20, 2025
21e016e
feat(finance): update src module description
Nfloc Feb 20, 2025
6c2e805
feat(finance): update src module description
Nfloc Feb 20, 2025
8916dd9
feat(finance): language revert change
Nfloc Feb 20, 2025
27cff74
test(finance): add length testcase
Nfloc Feb 21, 2025
4a65bee
feat(finance): Update finance.ts
Nfloc Feb 22, 2025
d5d63c3
feat(finance): Update index.ts
Nfloc Feb 22, 2025
d71330d
Merge branch 'next' into next
ST-DDT Feb 28, 2025
bb91ba4
Merge branch 'next' into next
ST-DDT Mar 1, 2025
afc1fc0
Merge branch 'next' into next
ST-DDT Mar 6, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/definitions/finance.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export type FinanceDefinition = LocaleEntry<{
credit_card: { [issuer: string]: string[] };

/**
* Currencies including their name, code and symbol (e.g. `US Dollar` / `USD` / `$`).
* Currencies including their name, code, symbol and ISO numID (e.g. `US Dollar` / `USD` / `$` / 840).
*/
currency: Currency[];

Expand Down
1 change: 1 addition & 0 deletions src/locales/el/finance/currency.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@ export default [
name: 'Ευρώ',
code: 'EUR',
symbol: '€',
numID: 978,
},
];
Loading