Skip to content
This repository has been archived by the owner on Apr 8, 2024. It is now read-only.

Change default varchar size in redshift to 65535 #899

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

dnascimento
Copy link
Contributor

@dnascimento dnascimento commented Aug 29, 2023

Description

As mentioned in https://discord.com/channels/908693336280432750/940966301680156683/941335732923007056

The default value for varchar in dbt-fal is 256, which is too small for many applications. This changes the default to max so that most of models work without problem.

@dnascimento dnascimento marked this pull request as draft August 29, 2023 11:46
@dnascimento dnascimento marked this pull request as ready for review August 29, 2023 11:56
Copy link
Member

@chamini2 chamini2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great! Thanks

@dnascimento
Copy link
Contributor Author

@chamini2 who can merge it?

As mentioned in https://discord.com/channels/908693336280432750/940966301680156683/941335732923007056

The default value for varchar in dbt-fal is 256, which is too small for many applications.
This changes the default to max so that most of models work without problem.
@dnascimento dnascimento force-pushed the varchar_lengths_default branch from a15ef4a to f71ac57 Compare August 29, 2023 23:21
@chamini2 chamini2 merged commit 8b2dabe into fal-ai:main Aug 30, 2023
@chamini2
Copy link
Member

Thanks @dnascimento . I will make a release this week!

@chamini2
Copy link
Member

chamini2 commented Sep 4, 2023

released at https://pypi.org/project/dbt-fal/1.5.9/

thanks for the contribution!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants