Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(resp): add option to disable XML serialization of errors #2356

Merged
merged 6 commits into from
Oct 6, 2024

Conversation

CaselIT
Copy link
Member

@CaselIT CaselIT commented Oct 4, 2024

Fixes #2355

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5ce771e) to head (a864d09).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2356   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           64        64           
  Lines         7712      7721    +9     
  Branches      1267      1269    +2     
=========================================
+ Hits          7712      7721    +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CaselIT CaselIT requested a review from vytas7 October 4, 2024 20:39
@vytas7 vytas7 changed the title Add option to enable xml serialization on errors. feat(resp): add option to disable XML serialization of errors Oct 5, 2024
@vytas7
Copy link
Member

vytas7 commented Oct 5, 2024

Not directly related to this PR, but it seems we also need to update the wording of docs for App.set_error_serializer() regarding media handlers.

Copy link
Member

@vytas7 vytas7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just the docs need a bit polish, and I would prefer another name for the option itself (but I don't have very good suggestions).

@vytas7 vytas7 modified the milestone: Version 4.0 Oct 5, 2024
@CaselIT CaselIT requested a review from vytas7 October 5, 2024 19:27
Copy link
Member

@vytas7 vytas7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks for this improvement 👍
We do want to get rid of any XML support out of the box, although we may want to add XML handlers in the future, either out of the box, or as a recipe, or an add-on library.

I would still like to polish docstrings and the proposed newsfragment, but I can try to address that in a followup PR.

Edit: got the ball rolling in #2358.

@vytas7 vytas7 merged commit a29c789 into falconry:master Oct 6, 2024
32 checks passed
@CaselIT CaselIT deleted the disable_serialize_to_xml branch October 6, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add flag to disable XML serialization; deprecate HTTPError.to_xml()
2 participants