Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync: release 0.18.2 #2157

Merged
merged 45 commits into from
Nov 20, 2024
Merged

sync: release 0.18.2 #2157

merged 45 commits into from
Nov 20, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Nov 13, 2024 •
edited
Loading

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Cherrypicks:

from master.

Also, it cherry-picks all CI changes from master to be able to successfully pass CI checks.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@Andreagit97 @FedeDP
fix(modern): check cred field is not NULL before the access
9136650 
Signed-off-by: Andrea Terzolo <[email protected]>
@Andreagit97 @FedeDP
cleanup: move sched_p_exec tail calls
e214eb3 
With this new approach the tail calls are only visible inside the
sched_proc_exec file.

Signed-off-by: Andrea Terzolo <[email protected]>
@Andreagit97 @FedeDP
cleanup: move sched_p_fork tail calls
e9a8ced 
Signed-off-by: Andrea Terzolo <[email protected]>
@Andreagit97 @FedeDP
cleanup: move hotplug logic into sys_exit
00a6a39 
Signed-off-by: Andrea Terzolo <[email protected]>
@Andreagit97 @FedeDP
cleanup: simplify droppping logic for tracepoint
dabbaf7 
Signed-off-by: Andrea Terzolo <[email protected]>
@Andreagit97 @FedeDP
update: set sched_switch as UF_ALWAYS_DROP
70033a4 
Signed-off-by: Andrea Terzolo <[email protected]>
@Andreagit97 @FedeDP
cleanup: rename some methods
cc7c36c 
Signed-off-by: Andrea Terzolo <[email protected]>
@Andreagit97 @FedeDP
cleanup: don't initialize enums if not needed
38cceec 
Signed-off-by: Andrea Terzolo <[email protected]>
@Andreagit97 @FedeDP
cleanup: remove ctx
27e12c9 
Signed-off-by: Andrea Terzolo <[email protected]>
@Andreagit97 @FedeDP
cleanup(tests): improve test stability
070cee3 
Signed-off-by: Andrea Terzolo <[email protected]>
@FedeDP
Copy link
Contributor Author

FedeDP commented Nov 13, 2024

/milestone 0.18.2

@poiana poiana added this to the 0.18.2 milestone Nov 13, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2024 •
edited
Loading

Please double check driver/SCHEMA_VERSION file. See versioning.

/hold

@FedeDP
Copy link
Contributor Author

FedeDP commented Nov 13, 2024

/hold until we wait for more info on remaining issue in falcosecurity/falco#3323

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2024 •
edited
Loading

Perf diff from master - unit tests

     3.21%     +1.17%  [.] sinsp_evt::load_params
     3.28%     +1.16%  [.] sinsp_parser::process_event
    10.08%     +0.97%  [.] sinsp_parser::reset
     5.60%     +0.95%  [.] sinsp_evt::get_type
     3.70%     -0.91%  [.] sinsp_thread_manager::find_thread
     2.27%     -0.86%  [.] sinsp::fetch_next_event
     1.04%     -0.75%  [.] std::_Hashtable<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, libsinsp::state::dynamic_struct::field_info>, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, libsinsp::state::dynamic_struct::field_info> >, std::__detail::_Select1st, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true> >::_M_find_before_node
     7.08%     -0.74%  [.] sinsp::next
     0.85%     +0.63%  [.] sinsp_parser::event_cleanup
     1.31%     -0.59%  [.] std::_Hashtable<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, libsinsp::state::dynamic_struct::field_info>, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, libsinsp::state::dynamic_struct::field_info> >, std::__detail::_Select1st, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true> >::find

Heap diff from master - unit tests

peak heap memory consumption: 7.05M
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 412.16K
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0108         -0.0108           146           145           146           145
BM_sinsp_split_median                                          -0.0110         -0.0110           146           145           146           145
BM_sinsp_split_stddev                                          -0.0517         -0.0508             1             0             1             0
BM_sinsp_split_cv                                              -0.0413         -0.0404             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.2035         -0.2035            60            48            60            48
BM_sinsp_concatenate_paths_relative_path_median                -0.1919         -0.1919            60            48            60            48
BM_sinsp_concatenate_paths_relative_path_stddev               +11.9301        +11.9336             0             2             0             2
BM_sinsp_concatenate_paths_relative_path_cv                   +15.2340        +15.2384             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.3134         -0.3134            25            17            25            17
BM_sinsp_concatenate_paths_empty_path_median                   -0.3191         -0.3190            25            17            25            17
BM_sinsp_concatenate_paths_empty_path_stddev                   +1.0992         +1.0978             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       +2.0572         +2.0551             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.2019         -0.2020            62            49            62            49
BM_sinsp_concatenate_paths_absolute_path_median                -0.2045         -0.2045            62            49            62            49
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.0405         -0.0402             1             1             1             1
BM_sinsp_concatenate_paths_absolute_path_cv                    +0.2023         +0.2027             0             0             0             0
BM_sinsp_split_container_image_mean                            -0.0535         -0.0535           373           353           373           353
BM_sinsp_split_container_image_median                          -0.0509         -0.0509           372           353           372           353
BM_sinsp_split_container_image_stddev                          +0.5464         +0.5461             3             4             3             4
BM_sinsp_split_container_image_cv                              +0.6338         +0.6335             0             0             0             0

@FedeDP
Copy link
Contributor Author

FedeDP commented Nov 13, 2024

We will probably need to cherry pick also all CI changes...

leogr
leogr previously approved these changes Nov 16, 2024
View reviewed changes
@poiana poiana added the lgtm label Nov 16, 2024
@leogr
Copy link
Member

leogr commented Nov 16, 2024

We will probably need to cherry pick also all CI changes...

@FedeDP let me know, I can re-approve, eventually

FedeDP and others added 12 commits November 18, 2024 09:31
@FedeDP
fix(ci): use process.exit(); to leave node script in github/action-…
e9168ca 
…script.

Signed-off-by: Federico Di Pierro <[email protected]>
@FedeDP
fix(ci): create-comment workflows array length check.
9387467 
Signed-off-by: Federico Di Pierro <[email protected]>
@dependabot @FedeDP
chore(deps): Bump uraimo/run-on-arch-action in the actions group
a152203 
Bumps the actions group with 1 update: [uraimo/run-on-arch-action](https://github.com/uraimo/run-on-arch-action).


Updates `uraimo/run-on-arch-action` from 2.7.2 to 2.8.1
- [Release notes](https://github.com/uraimo/run-on-arch-action/releases)
- [Commits](uraimo/run-on-arch-action@b0ffb25...5397f9e)

---
updated-dependencies:
- dependency-name: uraimo/run-on-arch-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: actions
...

Signed-off-by: dependabot[bot] <[email protected]>
@FedeDP
chore(ci): keep zig development version alive by using actions/cache.
1a50aba 
Signed-off-by: Federico Di Pierro <[email protected]>
@FedeDP
chore(ci): bump the zig version to latest.
ef5a56d 
Moreover, use zig version as cache key too.

Signed-off-by: Federico Di Pierro <[email protected]>
@FedeDP
chore(ci): bump zig version and improve install-zig action.
8a2665b 
Signed-off-by: Federico Di Pierro <[email protected]>
@FedeDP
fix(ci): fixed create-comment-kernel-testing typo.
3ff318d 
Signed-off-by: Federico Di Pierro <[email protected]>
@FedeDP
chore(ci): increase timeout to 5minutes for driverkit build in latest…
d0c5297 
…-kernel workflow.

Signed-off-by: Federico Di Pierro <[email protected]>
@FedeDP
update(ci): use cncf provided self hosted runners for arm64.
2a67310 
Signed-off-by: Federico Di Pierro <[email protected]>
@dependabot @FedeDP
chore(deps): Bump the actions group with 3 updates
70f0538 
Bumps the actions group with 3 updates: [actions/checkout](https://github.com/actions/checkout), [actions/cache](https://github.com/actions/cache) and [actions/setup-python](https://github.com/actions/setup-python).


Updates `actions/checkout` from 4.2.1 to 4.2.2
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@eef6144...11bd719)

Updates `actions/cache` from 4.1.1 to 4.1.2
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@3624ceb...6849a64)

Updates `actions/setup-python` from 5.2.0 to 5.3.0
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@f677139...0b93645)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: actions
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: actions
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: actions
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @FedeDP
chore(deps): Bump softprops/action-gh-release from 1 to 2
8e0c741 
Bumps [softprops/action-gh-release](https://github.com/softprops/action-gh-release) from 1 to 2.
- [Release notes](https://github.com/softprops/action-gh-release/releases)
- [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md)
- [Commits](softprops/action-gh-release@de2c0eb...c062e08)

---
updated-dependencies:
- dependency-name: softprops/action-gh-release
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @FedeDP
chore(deps): Bump softprops/action-gh-release in the actions group
89cb0d3 
Bumps the actions group with 1 update: [softprops/action-gh-release](https://github.com/softprops/action-gh-release).


Updates `softprops/action-gh-release` from 2.0.8 to 2.0.9
- [Release notes](https://github.com/softprops/action-gh-release/releases)
- [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md)
- [Commits](softprops/action-gh-release@c062e08...e7a8f85)

---
updated-dependencies:
- dependency-name: softprops/action-gh-release
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: actions
...

Signed-off-by: dependabot[bot] <[email protected]>
@FedeDP
Copy link
Contributor Author

FedeDP commented Nov 18, 2024

/unhold

@FedeDP
Copy link
Contributor Author

FedeDP commented Nov 18, 2024

/hold

@codecov Codecov
Copy link

codecov bot commented Nov 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release/0.18.x@e1999d0). Learn more about missing BASE report.

Additional details and impacted files 
@@                Coverage Diff                @@
##             release/0.18.x    #2157   +/-   ##
=================================================
  Coverage                  ?   74.35%           
=================================================
  Files                     ?      253           
  Lines                     ?    32951           
  Branches                  ?     5690           
=================================================
  Hits                      ?    24500           
  Misses                    ?     8451           
  Partials                  ?        0
Flag Coverage Δ
libsinsp 74.35% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@FedeDP
Copy link
Contributor Author

FedeDP commented Nov 18, 2024

Zig jobs require some changes to cmake and some more stuff; my advice is to disable their requirement from test-infra, merge this PR, and then enable them back.

@github-actions GitHub Actions
Copy link

X64 kernel testing matrix

KERNEL CMAKE-CONFIGURE KMOD BUILD KMOD SCAP-OPEN BPF-PROBE BUILD BPF-PROBE SCAP-OPEN MODERN-BPF SCAP-OPEN
amazonlinux2-4.19 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2-5.10 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2-5.15 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2-5.4 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2022-5.15 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2023-6.1 🟢 🟢 🟢 🟢 🟢 🟢
archlinux-6.0 🟢 🟢 🟢 🟢 🟢 🟢
archlinux-6.7 🟢 🟢 🟢 🟢 🟢 🟢
centos-3.10 🟢 🟢 🟢 🟡 🟡 🟡
centos-4.18 🟢 🟢 🟢 🟢 🟢 🟢
centos-5.14 🟢 🟢 🟢 🟢 🟢 🟢
fedora-5.17 🟢 🟢 🟢 🟢 🟢 🟢
fedora-5.8 🟢 🟢 🟢 🟢 🟢 🟢
fedora-6.2 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-3.10 🟢 🟢 🟢 🟡 🟡 🟡
oraclelinux-4.14 🟢 🟢 🟢 🟢 🟢 🟡
oraclelinux-5.15 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-5.4 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-4.15 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-5.8 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-6.5 🟢 🟢 🟢 🟢 🟢 🟢

ARM64 kernel testing matrix

KERNEL CMAKE-CONFIGURE KMOD BUILD KMOD SCAP-OPEN BPF-PROBE BUILD BPF-PROBE SCAP-OPEN MODERN-BPF SCAP-OPEN
amazonlinux2-5.4 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2022-5.15 🟢 🟢 🟢 🟢 🟢 🟢
fedora-6.2 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-4.14 🟢 🟢 🟢 🟡 🟡 🟡
oraclelinux-5.15 🟢 🟢 🟢 🟢 🟢 🟢
ubuntu-6.5 🟢 🟢 🟢 🟢 🟢 🟢

@FedeDP
Copy link
Contributor Author

FedeDP commented Nov 20, 2024

/unhold

@Andreagit97 Andreagit97 mentioned this pull request Nov 20, 2024
Merged
Andreagit97
Andreagit97 approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Nov 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Andreagit97
Copy link
Member

falcosecurity/test-infra#1697

@poiana poiana merged commit a414ad3 into release/0.18.x Nov 20, 2024
53 of 57 checks passed
@poiana poiana deleted the sync/release_0.18.2 branch November 20, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andreagit97 Andreagit97 Andreagit97 approved these changes

@leogr leogr leogr approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

Assignees

@leogr leogr

@Andreagit97 Andreagit97

Labels
approved dco-signoff: yes kind/cleanup lgtm release-note-none size/XXL
Projects
None yet
Milestone
0.18.2
Development

Successfully merging this pull request may close these issues.
6 participants
@FedeDP @leogr @poiana @Andreagit97 @Molter73 @cpanato