stricter lints #1597
Merged
stricter lints #1597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nico-famedly
force-pushed
the
nico/stricter-lints
branch
2 times, most recently
from
f9cfa17 to
1e57d21
Compare
nico-famedly
force-pushed
the
nico/stricter-lints
branch
from
2f59072 to
55a52ab
Compare
I don't see why they should be running in root, when you catch all their exceptions. I always thought runInRoot was for background requests,but those cases clearly were not supposed to run in the background. So I refactored runInRoot to not return a future and run stuff as a background request, which of course made it required to move stuff out, where we want to await the response. |
Merged
nico-famedly
force-pushed
the
nico/stricter-lints
branch
from
55a52ab to
1506395
Compare
krille-chan
reviewed
Nov 17, 2023
krille-chan
reviewed
Nov 17, 2023
BREAKING CHANGE: This changes the runInRoot method to not return a future. As a user, if you need the result of an async computation passed to runInRoot, please await it directly. Also the KeyVerification start and a few call methods now return a future.
nico-famedly
force-pushed
the
nico/stricter-lints
branch
from
1506395 to
f72d298
Compare
krille-chan
previously approved these changes
Nov 17, 2023
krille-chan
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess the only controversial change is the runInRoot stuff, but I don't see, why we would ever want to await those. The few cases, where we do, seem to fit better when we just await them directly?