Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do only convert linebreaks to br tags in p blocks #1609

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

krille-chan
Copy link
Contributor

This changes the behavior
of the markdown method to
only convert linebreaks inside
of p blocks. I found no better
solution yet for the problem
as otherwise also lists
will have linebreaks between
the list items. Unfortunately
the default linebreak syntax
seems not to fulfill our needs.

@krille-chan krille-chan force-pushed the krille/linebreaks-markdown branch from 91ac52d to f8607c4 Compare November 15, 2023 11:56
nico-famedly
nico-famedly previously approved these changes Nov 16, 2023
@nico-famedly
Copy link
Member

Ah, this breaks some tests. I guess this needs fixes :)

@krille-chan krille-chan force-pushed the krille/linebreaks-markdown branch from f8607c4 to 6096910 Compare November 22, 2023 09:57
This changes the behavior
of the markdown method to
only convert linebreaks inside
of p blocks. I found no better
solution yet for the problem
as otherwise also lists
will have linebreaks between
the list items. Unfortunately
the default linebreak syntax
seems not to fulfill our needs.
@krille-chan krille-chan merged commit c6e8b16 into main Nov 22, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants