Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GRIP next uri when pushpin routes use path_beg and replace_beg #115

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix GRIP next uri when pushpin routes use path_beg and replace_beg #115

wants to merge 1 commit into from

Conversation

timomeara
Copy link

  • adds django_eventstream.utils.build_next_uri method to build next uri
  • use settings.EVENTSTREAM_PATH_PREPEND value if present to build correct next uri

@timomeara timomeara mentioned this pull request Apr 28, 2023
Open
@jkarneges
Copy link
Member

Thanks for the report and PR! The change seems reasonable, although I'd think proxying to any Django app by subpath would have this problem and I wonder if there isn't a more general solution. For example, prepending the value of get_script_prefix. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timomeara @jkarneges