fix: Fix peer check job not actually starting

farcasterxyz · Nov 3, 2023 · c37b513 · c37b513
1 parent 9637457
commit c37b513
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/.changeset/tricky-birds-move.md b/.changeset/tricky-birds-move.md
@@ -0,0 +1,5 @@
+---
+"@farcaster/hubble": patch
+---
+
+fix: Fix peer check job not actually starting
diff --git a/apps/hubble/src/network/p2p/gossipNode.ts b/apps/hubble/src/network/p2p/gossipNode.ts
@@ -292,6 +292,7 @@ export class GossipNode extends TypedEmitter<NodeEvents> {
 
     // Also start the periodic job to make sure we have peers
     this._periodicPeerCheckJob = new PeriodicPeerCheckScheduler(this, bootstrapAddrs);
+    this._periodicPeerCheckJob.start();
 
     return ok(undefined);
   }

diff --git a/apps/hubble/src/network/p2p/periodicPeerCheck.ts b/apps/hubble/src/network/p2p/periodicPeerCheck.ts
@@ -4,7 +4,7 @@ import cron from "node-cron";
 import { GossipNode } from "./gossipNode.js";
 
 const log = logger.child({
-  component: "PeriodicSyncJob",
+  component: "PeriodicPeerCheckScheduler",
 });
 
 type SchedulerStatus = "started" | "stopped";
@@ -41,6 +41,10 @@ export class PeriodicPeerCheckScheduler {
 
   async doJobs() {
     // If there are no peers, try to connect to the bootstrap peers
+    const allPeerIds = await this._gossipNode.allPeerIds();
+    if (allPeerIds.length > 0) {
+      return;
+    }
     const result = await this._gossipNode.bootstrap(this._bootstrapPeers);
     if (result.isErr()) {
       log.warn({ err: result.error }, "No Connected Peers");