Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Warpcast follow count vs. Hub follow count is different #1557

Closed
manan19 opened this issue Nov 3, 2023 · 7 comments
Closed

bug: Warpcast follow count vs. Hub follow count is different #1557

manan19 opened this issue Nov 3, 2023 · 7 comments
Labels
s-triage Needs to be reviewed, designed and prioritized

Comments

@manan19
Copy link
Contributor

manan19 commented Nov 3, 2023

What is the bug?
image
Warpcast returns 8089 follow count for fid 194 https://vasco.wtf/fid/194

But the hubs return 8030

8030 follows for fid 194 from nemes.farcaster.xyz:2283
8030 follows for fid 194 from hoyt.farcaster.xyz:2283

How can it be reproduced? (optional)
getLinksByTarget on grpc port

@github-actions github-actions bot added the s-triage Needs to be reviewed, designed and prioritized label Nov 3, 2023
@manan19
Copy link
Contributor Author

manan19 commented Dec 4, 2023

@sanjayprabhu Will this be addressed by the linked PR?

@sanjayprabhu
Copy link
Contributor

No, it's some required apis to debug the issue. I haven't had time to investigate this yet. Probably this week.

@manan19
Copy link
Contributor Author

manan19 commented Dec 30, 2023

We're also seeing an issue with an inconsistency for casts. This is quite a severe issue for us since it is breaking all feeds across multiple customers that contain this cast.

example -
This cast exists on Warpcast https://warpcast.com/slokh/0x5ba7ea43
but it was never broadcasted over farcaster mainnet.

https://hoyt.farcaster.xyz:2281/v1/castById?fid=3887&hash=0x5ba7ea43dd642868947f9e9fbfd125246c233e93
https://nemes.farcaster.xyz:2281/v1/castById?fid=3887&hash=0x5ba7ea43dd642868947f9e9fbfd125246c233e93

The cast was recasted 3 times & all the recast events were broadcasted over the network. Shouldn't the hubs have rejected the recast events if the cast didn't exist, was revoked, pruned or deleted?

@sanjayprabhu
Copy link
Contributor

The above issue (which is unrelated to the count difference) should be fixed by #1610.

Also note that the hubs don't validate the target cast id. This is because they cannot rely on the messages arriving in order, so we have use less strict validations.

I'll leave this ticket open since I still want to get to the bottom of the count difference.

@manan19
Copy link
Contributor Author

manan19 commented Jan 5, 2024

@sanjayprabhu Do we need to make any changes after the fix lands in a hubble upgrade to get that deleted signer again?

@sanjayprabhu
Copy link
Contributor

Nope, hubble should fix itself on next sync (likely within 10-15 mins). I'm testing this now, and hoping to do a patch release later today.

@sds
Copy link
Member

sds commented Mar 7, 2024

Closing as this should be fixed. Thanks for the report!

@sds sds closed this as completed Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s-triage Needs to be reviewed, designed and prioritized
Projects
None yet
Development

No branches or pull requests

3 participants