Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add more information in the limits response #1569

Merged
merged 3 commits into from
Dec 4, 2023

Conversation

sanjayprabhu
Copy link
Contributor

@sanjayprabhu sanjayprabhu commented Nov 9, 2023

Motivation

Adds additional usage information about each users's storage so we can debug issues like #1557

Change Summary

Describe the changes being made in 1-2 concise sentences.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

Additional Context

If this is a relatively large or complex change, provide more details here that will help reviewers


PR-Codex overview

This PR focuses on adding usage information to the getCurrentStorageLimitsByFid RPC call.

Detailed summary

  • Added units field to the StorageLimitsResponse message in the request_response.proto file.
  • Added name, used, earliestTimestamp, and earliestHash fields to the StorageLimit message in the same file.
  • Implemented the unpackTsHash function in the message.ts file.
  • Added the getUsage method to the StoreEventHandler class in the storeEventHandler.ts file.

The following files were skipped due to too many changes: packages/hub-web/src/generated/request_response.ts, packages/hub-nodejs/src/generated/request_response.ts, packages/core/src/protobufs/generated/request_response.ts, apps/hubble/src/rpc/test/server.test.ts, packages/hub-web/src/generated/rpc.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Nov 9, 2023

🦋 Changeset detected

Latest commit: 67beaa7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@farcaster/hub-nodejs Patch
@farcaster/hub-web Patch
@farcaster/core Patch
@farcaster/hubble Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 10, 2023 11:36pm

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Files Coverage Δ
apps/hubble/src/storage/db/message.ts 90.00% <83.33%> (-0.25%) ⬇️
apps/hubble/src/storage/engine/index.ts 83.67% <75.00%> (-0.14%) ⬇️
...pps/hubble/src/storage/stores/storeEventHandler.ts 87.97% <83.33%> (-0.51%) ⬇️

... and 2 files with indirect coverage changes

📢 Thoughts on this report? Let us know!

@sanjayprabhu sanjayprabhu merged commit 704e077 into farcasterxyz:main Dec 4, 2023
9 checks passed
@sanjayprabhu sanjayprabhu deleted the better_limits branch December 4, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant