Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support v2 id and key registry contracts #1526

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

sanjayprabhu
Copy link
Contributor

@sanjayprabhu sanjayprabhu commented Oct 17, 2023

Motivation

Support migrating to V2 Id and Key registry contracts

Future changes:

  • Drop old contract events from db and sync trie

Change Summary

Describe the changes being made in 1-2 concise sentences.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

Additional Context

If this is a relatively large or complex change, provide more details here that will help reviewers


PR-Codex overview

Detailed summary

  • Added a new field version to the OnChainEvent protobuf message
  • Removed the eventType check in the onChainEventStore.ts file
  • Added new options for L2 Farcaster contracts in the CLI
  • Updated the Hub class to handle the new V2 registry addresses

The following files were skipped due to too many changes: apps/hubble/www/docs/docs/cli.md, apps/hubble/src/network/utils/networkConfig.test.ts, apps/hubble/src/eth/l2EventsProvider.ts, apps/hubble/src/eth/abis.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2023

🦋 Changeset detected

Latest commit: 69cdc54

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@farcaster/hubble Minor
@farcaster/hub-nodejs Patch
@farcaster/hub-web Patch
@farcaster/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2023 0:28am

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Files Coverage Δ
apps/hubble/src/eth/abis.ts 100.00% <100.00%> (ø)
apps/hubble/src/network/sync/syncEngine.ts 75.63% <100.00%> (-0.57%) ⬇️
apps/hubble/src/network/utils/networkConfig.ts 41.37% <ø> (ø)
...pps/hubble/src/storage/stores/onChainEventStore.ts 95.53% <100.00%> (+0.08%) ⬆️
apps/hubble/src/eth/l2EventsProvider.ts 70.37% <96.00%> (+2.27%) ⬆️
apps/hubble/src/hubble.ts 52.96% <0.00%> (-0.18%) ⬇️
apps/hubble/src/storage/engine/index.ts 83.80% <71.42%> (-0.07%) ⬇️

... and 3 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@sanjayprabhu sanjayprabhu changed the title [wip] feat: support v2 id and key registry contracts feat: support v2 id and key registry contracts Oct 25, 2023
@sanjayprabhu sanjayprabhu added the t-feat Add a new feature or protocol improvement label Oct 25, 2023
@sanjayprabhu sanjayprabhu marked this pull request as ready for review October 25, 2023 00:29
@sanjayprabhu sanjayprabhu merged commit f3d3222 into farcasterxyz:main Oct 25, 2023
8 checks passed
@sanjayprabhu sanjayprabhu deleted the v2_contracts branch October 25, 2023 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-feat Add a new feature or protocol improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant