Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix stale contactInfo caches on SyncEngine #1541

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

sanjayprabhu
Copy link
Contributor

@sanjayprabhu sanjayprabhu commented Oct 19, 2023

Motivation

The contactInfo cache on SyncEngine would never get updated until the hub restarted. This results in the hub using old appVersions or addresses for peers. Now that we have timestamps, replace with the latest version if timestamp is newer.

Change Summary

Describe the changes being made in 1-2 concise sentences.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

Additional Context

If this is a relatively large or complex change, provide more details here that will help reviewers


PR-Codex overview

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@sanjayprabhu sanjayprabhu added the t-bug A fix for a bug with the current system label Oct 19, 2023
@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2023

🦋 Changeset detected

Latest commit: 6807b59

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@farcaster/hubble Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2023 11:55pm

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Files Coverage Δ
apps/hubble/src/network/sync/syncEngine.ts 75.63% <100.00%> (+0.31%) ⬆️
apps/hubble/src/hubble.ts 53.07% <50.00%> (-0.24%) ⬇️

📢 Thoughts on this report? Let us know!.

@sanjayprabhu sanjayprabhu merged commit 173c9d6 into farcasterxyz:main Oct 20, 2023
8 checks passed
@sanjayprabhu sanjayprabhu deleted the fix_contact_info_cache branch October 20, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-bug A fix for a bug with the current system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant