-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: hubble autoupgrade should ensure dependencies and clean unused docker data #1542
fix: hubble autoupgrade should ensure dependencies and clean unused docker data #1542
Conversation
🦋 Changeset detectedLatest commit: 04cb193 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ see 3 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
39c70f1
to
04cb193
Compare
@@ -9,7 +9,7 @@ services: | |||
hubble: | |||
image: farcasterxyz/hubble:latest | |||
pull_policy: always | |||
restart: unless-stopped |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was the restart policy changed from unless-stopped
to on-failure
?
Adding max 5 restarts makes sense, is this not available for unless-stopped
?
With on-failure
there is the problem that the container will not start after a host machine reboot, for example. The service is less resilient this way.
Motivation
Fixes #1528. And also docker volumes taking up too much space.
Change Summary
Describe the changes being made in 1-2 concise sentences.
Merge Checklist
Choose all relevant options below by adding an
x
now or at any time before submitting for reviewAdditional Context
If this is a relatively large or complex change, provide more details here that will help reviewers
PR-Codex overview
This PR focuses on fixing the hubble autoupgrade process by ensuring dependencies and cleaning unused docker data.
Detailed summary