Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hubble autoupgrade should ensure dependencies and clean unused docker data #1542

Merged
merged 4 commits into from
Oct 20, 2023

Conversation

sanjayprabhu
Copy link
Contributor

@sanjayprabhu sanjayprabhu commented Oct 20, 2023

Motivation

Fixes #1528. And also docker volumes taking up too much space.

Change Summary

Describe the changes being made in 1-2 concise sentences.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

Additional Context

If this is a relatively large or complex change, provide more details here that will help reviewers


PR-Codex overview

This PR focuses on fixing the hubble autoupgrade process by ensuring dependencies and cleaning unused docker data.

Detailed summary

  • Patched the "@farcaster/hubble" package.
  • Updated the restart policy in the hubble/docker-compose.yml file.
  • Added a check to skip self upgrade for easier testing.
  • Added a cleanup function to prune unused docker images and volumes.
  • Installed dependencies and docker as root in the autoupgrade script.
  • Added a sleep command before cleanup in the autoupgrade script.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@sanjayprabhu sanjayprabhu added the t-bug A fix for a bug with the current system label Oct 20, 2023
@changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2023

🦋 Changeset detected

Latest commit: 04cb193

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@farcaster/hubble Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2023 7:52pm

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

see 3 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@sanjayprabhu sanjayprabhu force-pushed the fix_autoupgrade_script branch from 39c70f1 to 04cb193 Compare October 20, 2023 19:51
@sanjayprabhu sanjayprabhu merged commit 559afd0 into farcasterxyz:main Oct 20, 2023
8 checks passed
@sanjayprabhu sanjayprabhu deleted the fix_autoupgrade_script branch October 20, 2023 20:07
@@ -9,7 +9,7 @@ services:
hubble:
image: farcasterxyz/hubble:latest
pull_policy: always
restart: unless-stopped
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was the restart policy changed from unless-stopped to on-failure?

Adding max 5 restarts makes sense, is this not available for unless-stopped?

With on-failure there is the problem that the container will not start after a host machine reboot, for example. The service is less resilient this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-bug A fix for a bug with the current system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(hubble): hubble autoupgrade script is broken
2 participants