Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ContactInfoContent signing + config toggle for strict validation + StrictNoSign #1545

Merged
merged 11 commits into from
Oct 26, 2023

reduce delay to 1s, shouldn't need to exceed

8ea555c
Select commit
Loading
Failed to load commit list.
Merged

feat: Add ContactInfoContent signing + config toggle for strict validation + StrictNoSign #1545

reduce delay to 1s, shouldn't need to exceed
8ea555c
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project succeeded Oct 26, 2023 in 1s

73.11% (target 70.00%)

View this Pull Request on Codecov

73.11% (target 70.00%)

Details

Codecov Report

Attention: 51 lines in your changes are missing coverage. Please review.

Files Coverage Δ
apps/hubble/src/network/p2p/gossipNode.ts 84.02% <100.00%> (+0.59%) ⬆️
apps/hubble/src/network/p2p/gossipNodeWorker.ts 23.73% <100.00%> (+0.24%) ⬆️
apps/hubble/src/network/sync/syncEngine.ts 76.19% <100.00%> (-0.15%) ⬇️
apps/hubble/src/network/utils/networkConfig.ts 43.33% <100.00%> (+1.95%) ⬆️
apps/hubble/src/rustfunctions.ts 100.00% <100.00%> (ø)
.../hubble/src/storage/jobs/updateNetworkConfigJob.ts 19.23% <0.00%> (-3.50%) ⬇️
packages/core/src/validations.ts 82.92% <12.50%> (-4.45%) ⬇️
apps/hubble/src/hubble.ts 53.36% <57.62%> (+0.40%) ⬆️

... and 2 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.