Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix peer check job not actually starting #1559

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

sanjayprabhu
Copy link
Contributor

@sanjayprabhu sanjayprabhu commented Nov 3, 2023

Motivation

The periodic peer check job was not actually started. So if bootstrap failed for any reason, the hub would never retry.

Change Summary

Describe the changes being made in 1-2 concise sentences.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

Additional Context

If this is a relatively large or complex change, provide more details here that will help reviewers


PR-Codex overview

Focus of the PR:

Fixing the issue where the peer check job was not starting properly.

Detailed summary:

  • Fixed the PeriodicPeerCheckScheduler component name in the logger.
  • Added a check to only connect to bootstrap peers if there are no existing peers.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@sanjayprabhu sanjayprabhu added the t-bug A fix for a bug with the current system label Nov 3, 2023
Copy link

changeset-bot bot commented Nov 3, 2023

🦋 Changeset detected

Latest commit: c37b513

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@farcaster/hubble Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 3, 2023 6:19pm

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Files Coverage Δ
apps/hubble/src/network/p2p/gossipNode.ts 84.61% <100.00%> (+0.07%) ⬆️
apps/hubble/src/network/p2p/periodicPeerCheck.ts 50.00% <0.00%> (+8.82%) ⬆️

... and 2 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@sanjayprabhu sanjayprabhu changed the base branch from main to 1_7_1 November 3, 2023 22:15
@sanjayprabhu sanjayprabhu merged commit 43bf8b0 into farcasterxyz:1_7_1 Nov 3, 2023
7 of 8 checks passed
@sanjayprabhu sanjayprabhu deleted the fix_bootstrap_job branch November 3, 2023 22:16
sanjayprabhu added a commit that referenced this pull request Nov 9, 2023
* fix: disallow empty casts (#1555)

* fix: Fix peer check job not actually starting (#1559)

* fix: Allow syncTrie to handle names that are substrings (#1546)

* fix: Allow syncTrie to handle names that are substrings

* Add migration to delete unpadded fnames from syncTrie

* changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-bug A fix for a bug with the current system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant